Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanctuary glyphs do not spawn on certain tiles #58

Closed
tmewett opened this issue Feb 22, 2020 · 4 comments · Fixed by #293
Closed

Sanctuary glyphs do not spawn on certain tiles #58

tmewett opened this issue Feb 22, 2020 · 4 comments · Fixed by #293
Labels
bug Something isn't working gameplay Affects the gameplay experience

Comments

@tmewett
Copy link
Owner

tmewett commented Feb 22, 2020

From leadduck:

About 200 moves before my sanctuary tiles failed to show up a Flamedancer had followed be down the stairs. Seems like the burning symbols nullify future changes to those tiles?

From clarus:

Scroll of Sanctuary will have no effect on obsidian tiles (cooled lava, around brimstone fields or created by dragon fire, seems to be classified as liquid or sth like that)
@tmewett tmewett added the bug Something isn't working label Feb 22, 2020
@tmewett
Copy link
Owner Author

tmewett commented Feb 23, 2020

Sanctuary glyphs spawn on the liquid layer. Clearing out the liquid layer when a glyph spawns would be unintuitive, as it would allow you to e.g. beach bog monsters or kraken that were grappling you in the middle of shallow water. Maybe we can move the glyph to the surface layer?

@tmewett tmewett added the gameplay Affects the gameplay experience label Mar 23, 2020
@withinwheels
Copy link
Contributor

On SURFACE we face a similar issue with (say) dense foliage. If we read the scroll in some bushes, the glyphs will not appear under them even after trampling.

The scroll could clear out the surface layer, which may be moderately more appropriate than doing so in the liquid layer. Notable surface layer things that such a scroll would then be able to demolish:

  • DF_BLOAT_EXPLOSION
  • DF_MUTATION_EXPLOSION
  • DF_MUTATION_LICHEN
  • DF_TUNNELIZE
  • DF_SHATTERING_SPELL
  • DF_SILENT_GLYPH_GLOW, DF_GUARDIAN_STEP, DF_MIRROR_TOTEM_STEP (other stone guardian glyphs?)
  • ..also various fires including brimstone, and flood trap water.

Not sure if I'm interpreting that dungeonFeaturesCatalog correctly though.

@withinwheels
Copy link
Contributor

Putting it on SURFACE (or DUNGEON for that matter) still does not allow the glyphs to form on brimstone it seems.

Or maybe I'm doing it wrong, I'm changing the .layer of the SACRED_GLYPH dungeonFeature entry.

@withinwheels
Copy link
Contributor

Placing the sacred glyphs in SURFACE allows the dungeon feature to spawn, but the glyph's own draw priority isn't high enough to draw over brimstone.

This was ultimately the original problem in LIQUID as well, where draw priority was used to determine if the glyphs could even be placed (they could not.) Now they're invisible but present (monsters won't walk over them.)

If I also raise the priority of the sacred glyph to be more important than the various fires, then they are indeed visible again and things are as perhaps they should. Alternately we could consider decreasing the priority of the fire.

withinwheels added a commit to withinwheels/BrogueCE that referenced this issue Apr 2, 2021
@withinwheels
Sacred glyphs in surface layer, have more prio
507fb81 
The glyphs from a scroll of sanctuary had a relatively unimportant draw
priority.  This means the glyphs cannot be placed where tiles in the
same layer have higher priority, such as brimstone.

Additionally, even if they are placed then greater-priority tiles in
*other* layers at that location would draw instead, effectively hiding
the glyphs.

Address both of these by giving sacred glyphs more priority, which is
realized by lowering the associated value.  In order to avoid destroying
e.g. water, they are also moved to the surface layer.  They destroy
bushes instead now.

Closes tmewett#58
@withinwheels withinwheels mentioned this issue Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gameplay Affects the gameplay experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sacred glyphs in surface layer, have more prio withinwheels/BrogueCE
2 participants
@tmewett @withinwheels