Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allies don't have lighter colour tint #86

Closed
tmewett opened this issue May 21, 2020 · 1 comment
Closed

Allies don't have lighter colour tint #86

tmewett opened this issue May 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@tmewett
Copy link
Owner

tmewett commented May 21, 2020

Reported by blossom. Screenshot from 1.8.2:

Screenshot from 1.8.3:

@tmewett tmewett added the bug Something isn't working label May 21, 2020
@tmewett
Copy link
Owner Author

tmewett commented Jun 14, 2020

The issue is this section of getCellAppearance in IO.c:

if (monst->creatureState == MONSTER_ALLY
    && (monst->info.displayChar >= 'a' && monst->info.displayChar <= 'z' || monst->info.displayChar >= 'A' && monst->info.displayChar <= 'Z')) {
    if (rogue.trueColorMode) {
        cellForeColor = white;
    } else {
        applyColorAverage(&cellForeColor, &pink, 50);
    }
}

The test for an alphabetical displayChar is so that summoned "ally-only" creatures such as guardian spirits and spectral blades aren't pink. We need an alternative to this test as displayChars are now a more generic enum type

SanatMishra pushed a commit to SanatMishra/BrogueCE that referenced this issue Sep 16, 2020
Previously the condition was that the monster has an alphabetical display
character; this was broken with the glyphs changes.

Closes: tmewett#86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant