Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve date validation. #1

Merged
merged 1 commit into from Feb 1, 2019
Merged

Improve date validation. #1

merged 1 commit into from Feb 1, 2019

Conversation

klarsson
Copy link

SCIM dates are represented as a string, but the validator would only accept DateTime php objects.

This patch extends the the type validation for DateTime attributes to allow for valid date strings.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 70.173% when pulling 3931f7f on klarsson:improve_datetime into 95a5900 on tmilos:master.

@tmilos tmilos merged commit 34e9cf4 into tmilos:master Feb 1, 2019
@tmilos
Copy link
Owner

tmilos commented Feb 1, 2019

Thanks

@klarsson klarsson deleted the improve_datetime branch February 1, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@klarsson @coveralls @tmilos @kimql