Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change underlying mode for FreeDV LSB to DIGL #46

Merged
merged 1 commit into from
May 31, 2024

Conversation

amcdermond
Copy link
Contributor

@amcdermond amcdermond commented May 28, 2024

The underlying mode should be DIGL for LSB similar to how it is DIGU for USB. This will disable any audio processing including CESSB and TX equalization that could corrupt the waveform.


Before merging:

  • All CI actions must build without errors.
  • If the PR adds new user-facing functionality, this must be documented in the user guide. The Markdown files in the manual folder should be modified for this purpose.

The underlying mode should be DIGL for LSB similar to how it is DIGU
for USB.  This will disable any audio processing including CESSB and
TX equalization that could corrupt the waveform.
@tmiw
Copy link
Owner

tmiw commented May 29, 2024

Thanks for the change! DIGL seems to work here. However, I did notice something with the filters that I'm not sure is related. Here's what I did:

  1. Set slice A to FDVL and restart SmartSDR. The filter looks as expected:

Screenshot 2024-05-28 at 8 17 09 PM

  1. Switch slice A to FDVU, then back to FDVL. SmartSDR still shows the filter as though it's in FDVU:

Screenshot 2024-05-28 at 8 17 19 PM

TX does still look like it's behaving properly in FDVL, though, in that it's transmitting the signal below the dial frequency.

Anyway, if that filter thing is a known issue I can go ahead and merge.

@tmiw
Copy link
Owner

tmiw commented May 31, 2024

Actually, I think that filter thing might be an ezDV bug. I'll go ahead and merge this since it otherwise seems to be working okay.

@tmiw tmiw merged commit e6c5e32 into tmiw:main May 31, 2024
@amcdermond
Copy link
Contributor Author

amcdermond commented May 31, 2024 via email

@tmiw
Copy link
Owner

tmiw commented Jun 1, 2024

No worries and thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants