Repetition when Pressing Function Keys

[MarioRicalde]

If you use Fast "Key Repeat" and Short "Delay Until Repeat" like in this image:

You will randomly get repetitions for letters and backspaces, to reproduce try the following;

1. Press any letter OR backspace and immediately press FN.
2. See it repeat several times.

Example of what you should expect to see:

aaaaa
ssss
eeee
rrrrr
tttt
yyyyyy
uuuuuu
pppppp

[MarioRicalde]

This definitely has to do with TAPPING_TERM, lowered it and the problem went away. It's definitely an issue, though.

[tmk]

Ubuntu has keyboard setting dialog like this.

WIth this crazy fastest repeat and shortest delay I can't type at all with both tmk controller and stock controller(Topre).
In my case FN is not related to this. It doesn't seem your issue comes from tmk controller.

I'm not sure exactly what your problem is. Your problem may come from your keymap. Post you keymap.c.

Are you sure that you can type collectly with this extream setting with your other keyboard? Which keyboard do you use?

BTW, do you really need this extreme repeating setting? :)

This is what I got with the setting.
aaaaaaaaaaaaaaaaaa
sssssssssssss
dddddddddddddddddddd
fffffffffffffff
gggggggggggg
hhhhhhhhhh
iiiiiiiiiiiiii ccccccccccccccccccccccaaaaaaaaaaaaaaaaannnnnnnnnnnnnnnnn''''''''''''''''''''''''' tttttttttt tttttttttttttttyyyyyyyyyyyyyyyyppppppppppppppppppppppeeeeeeeeeeeeeeeeee!!!!!!!!!!!!!!!!!!!!!!!!

[MarioRicalde]

In the case of Mac OSX I don't think that it's that crazy fast.

I'm using a HHKB using the default keymap.c that in this repo. The problem happens only when you type any letter and right after that a FN key. It also happens with backspace, which makes it somewhat annoying when you're using shift as a function key.

The way I noticed this issue was by quickly typing "hello!", where the exclamation mark turns the text output into: "helloooooo!".

[MarioRicalde]

Steps to reproduce:

Type "hello" immediately followed by "Shift + 1 ( ! )".
Expected result: hello!
Actual result: helloooo!

Type "a" immediately followed by pressing and holding FN button on the HHKB.
Expected result: a
Actual result: aaaa

Hit BACKSPACE followed by the HHKB FN key in the following string: "HelloWorld"
Expected result: "HelloWorl"
Actual result: "He"

[tmk]

Ah, I finally got this problem. Thanks for your patience and explanation.
It is exactly a problem on tapping code. I'll look into this problem later.

I can't believe I didn't catch this anonying bug for long time. Maybe because I usually use long delay and slow repeating rate.

Plz use very long delay(around 500ms?) until this is fixed. Long delay will mitigate this problem, I think.

[MarioRicalde]

I virtualised Ubuntu and got it to fail similarly to my Mac OSX System:

[MarioRicalde]

@tmk thank you! expect me to be helping more with the documentation, I plan to use this every day !

Kudos!

[tmk]

I pushed fix to new branch 'tapping_fix60'. Can you try this code?
https://github.com/tmk/tmk_keyboard/tree/tapping_fix60
This is the fix commit.
4d0b3aa

I'll merge this into master branch after some test run.

Bug description:

Tap key prevetns processing key release event till settlement of tapping(TAPPING_TERM(200ms) at worst). As the result of this unexpected repeating occurs even if the key is alreadly released.

key sequence:

key ~~~~_____~~~~~~~~~~                   
tap ~~~~~~~_______~~~~~                   
          |--------|  TAPPING_TERM

This bug apears when you press Tap key druing pressing a normal key, especially using OS keyboard setting with relatively short 'Delay'(< 200ms) and fast 'Rate/Speed'( > 30strokes/min).

Workaround

Longer Repeat Dealy than TAPPING_TERM(200ms) should help.

[MarioRicalde]

It works!

I just tested everything and it's working perfectly now.

どうも 有難う 御座います.

[MarioRicalde]

Hello! I've been using this for a whole day of work ( typed a lot ! ) and I got no errors at all!

Kudos!

[MarioRicalde]

I think it's ready for merge into master?

[tmk]

I also didn't got problem so far. I merged into master branch now. 58ca7b9

Thanks.