Provide a C_STATE value of 'Outside United States' for SageGateway wh…

…en processing international customers
tmm1 · Oct 6, 2009 · 39e6eb0 · 39e6eb0
1 parent 411046a
commit 39e6eb0
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,6 @@
 = ActiveMerchant CHANGELOG
 
+* Provide a C_STATE value of "Outside United States" for SageGateway when processing international customers [cody]
 * PayPal Website Payments Pro Canada supports Amex [cody]
 * Add line item support for LinkpointGateway. [Tony Primerano]
 * Add support for SallieMae gateway [iamjwc]

diff --git a/lib/active_merchant/billing/gateways/sage/sage_core.rb b/lib/active_merchant/billing/gateways/sage/sage_core.rb
@@ -55,7 +55,13 @@ def add_addresses(post, options)
 
         post[:C_address]    = billing_address[:address1]
         post[:C_city]       = billing_address[:city]
-        post[:C_state]      = billing_address[:state]
+
+        if ['US', 'CA'].include?(billing_address[:country])
+          post[:C_state]    = billing_address[:state]
+        else
+          post[:C_state]    = "Outside of United States"
+        end
+
         post[:C_zip]        = billing_address[:zip]
         post[:C_country]    = billing_address[:country] 
         post[:C_telephone]  = billing_address[:phone]

diff --git a/test/unit/gateways/sage_bankcard_test.rb b/test/unit/gateways/sage_bankcard_test.rb
@@ -138,7 +138,41 @@ def test_cvv_result
     response = @gateway.purchase(@amount, @credit_card, @options)
     assert_equal 'M', response.cvv_result['code']
   end
-
+
+  def test_us_address_with_state
+    post = {}
+    options = {
+      :billing_address => { :country => "US", :state => "CA"}
+    }
+    @gateway.send(:add_addresses, post, options)
+
+    assert_equal "US", post[:C_country]
+    assert_equal "CA", post[:C_state]
+  end
+
+  def test_us_address_without_state
+    post = {}
+    options = {
+      :billing_address => { :country => "US", :state => ""}
+    }
+    @gateway.send(:add_addresses, post, options)
+
+    assert_equal "US", post[:C_country]
+    assert_equal "", post[:C_state]
+  end
+
+
+  def test_international_address_without_state
+    post = {}
+    options = {
+      :billing_address => { :country => "JP", :state => ""}
+    }
+    @gateway.send(:add_addresses, post, options)
+
+    assert_equal "JP", post[:C_country]
+    assert_equal "Outside of United States", post[:C_state]
+  end
+
   private
   def successful_authorization_response
     "\002A911911APPROVED                        00MX001234567890\0341000\0340\034\003"