Clean up and improve terminology around distributed builds #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This at least as clear and avoids problematic terminology.
Distributed builds use a single central master and one or more remote masters. All masters have workers.
The relay token check is now handled before this point.
This matches the terminology used in the rest of the library and makes it clearer that this message comes from a remote master process instead of from a worker.
This matches the terminology used throughout the gem and makes it clearer that this message comes from a remote master process, not from a worker process.
bhuga
approved these changes
Mar 8, 2017
|
Yes, a test is a good idea. I'll add one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributed builds use a single central master and one or more remote masters. All masters have workers. We no longer call anything a "slave", which is both problematic on its own and could be confusing as to whether it referred to a remote master or a worker.
This is a breaking change.