Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Signed Commits Requirement to Contributing Docs #117

Closed
phenixblue opened this issue Jan 10, 2022 · 3 comments · Fixed by #119
Closed

Add documentation for Signed Commits Requirement to Contributing Docs #117

phenixblue opened this issue Jan 10, 2022 · 3 comments · Fixed by #119
Labels
contrib Related to Contributors or the Contribution process documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@phenixblue
Copy link
Contributor

What would you like to be added:

Need to add verbiage to specify the requirement for signed commits for all contributions to the Contributing Docs

Why is this needed:

More clarity for prerequisites for new contributors.

@phenixblue phenixblue added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed contrib Related to Contributors or the Contribution process labels Jan 10, 2022
@pramod74
Copy link
Contributor

Hi @phenixblue,

I would like to take up this issue. Is there some specific verbiage related to requirement for signed commits that needs to be added?

Thanks,
Pramod

@phenixblue
Copy link
Contributor Author

Hello @pramod74 ,thanks for offering to help.

Nothing specific other than some verbiage that describes commit signing as a requirement.

I think it should probably go in the Submitting a PR section.

It would be good to link to Github's documentation on setting up commit signing

@pramod74
Copy link
Contributor

Thanks, @phenixblue.

I have made an attempt and raised a PR. Kindly review.

@phenixblue phenixblue linked a pull request Apr 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib Related to Contributors or the Contribution process documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants