Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CONTRIBUTING.md #119

Merged
merged 3 commits into from
Jan 23, 2022
Merged

Conversation

pramod74
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind bug
/kind cleanup
/kind deprecation
/kind design

/kind documentation

/kind feature
/kind release

What this PR does / why we need it:
Added documentation on requiring signed commits in CONTRIBUTING.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., usage docs, etc.:


@pramod74 pramod74 requested a review from a team as a code owner January 12, 2022 18:57
Copy link
Contributor

@phenixblue phenixblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the extra whitespace added before the title

CONTRIBUTING.md Outdated Show resolved Hide resolved
…te-contributing-md

Fetching changes from remote repository before committing issue fix
Copy link
Contributor

@phenixblue phenixblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@phenixblue phenixblue merged commit b8c37cb into tmobile:master Jan 23, 2022
@pramod74
Copy link
Contributor Author

/lgtm

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for Signed Commits Requirement to Contributing Docs
2 participants