Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for writing file with a given encoding #38

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Add support for writing file with a given encoding #38

merged 1 commit into from
Aug 24, 2022

Conversation

tmontaigu
Copy link
Owner

@tmontaigu tmontaigu commented Aug 15, 2022 •
edited
Loading

  • Add support for writing with given encoding, code page support via yore crate
  • Fix writing of visual fox pro file (the backlink was not written, we actually don't write it, but we pad with zeros)
  • Breaking changes since the Encoding appears in type signatures

@tmontaigu
Add support for writing file with a given encoding
f160384 
- Add support for writing with given encoding, code page support via `yore` crate
- Fix writing of visual fox pro file (the backlink was not written, we actually don't write it, but we pad with zeros)
- Breaking changes since the Encoding appears in type signatures
@tmontaigu
Copy link
Owner Author

I'm wondering if we should keep the fact that the Encoding used appears as a generic.
we should probably hide this and use a Box to keep the api simple.

@tmontaigu
Copy link
Owner Author

Gonna do this in another PR

@tmontaigu tmontaigu merged commit f160384 into master Aug 24, 2022
@tmontaigu tmontaigu deleted the custom-encodings-write branch August 24, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tmontaigu