New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for off by one error in file #76

Closed

casperhart wants to merge 1 commit into tmontaigu:master from casperhart:off-by-one

Contributor

casperhart commented Oct 25, 2023

move record_position() function from header.rs to file.rs
calculate record size as sum of field lengths for all seeking / file operations, as it's unclear whether the record size from the header will include deletion flag or not. This effectively ignores the record_length from the header except when writing.

In the changes here, the record_length does not include the deletion flag, but I can update to include the deletion flag if that's preferred.


          fix for off by one error in file

casperhart mentioned this pull request

Fix off by one error in dbase::File #75

Merged

casperhart closed this

Contributor Author

casperhart commented Oct 28, 2023

Closed in favour of #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment