Merge branch 'travis-test'

.travis.yml

@@ -0,0 +1,11 @@
+  language: python
+  python:
+    - "3.6"
+
+  install:
+    - pip install -r requirements.txt
+    - pip install lazperf
+
+  script:
+    - pytest pylastests
+    - pytest pylas # doctests

pylas/compression.py

@@ -88,7 +88,7 @@ def compress_buffer(uncompressed_buffer, record_schema, offset):
     return compressed
 
 
-def _pass_through_laszip(stream, action="decompress"):
+def find_laszip_executable():
     laszip_names = ("laszip", "laszip.exe", "laszip-cli", "laszip-cli.exe")
 
     for binary in laszip_names:
@@ -97,9 +97,15 @@ def _pass_through_laszip(stream, action="decompress"):
             for x in os.environ["PATH"].split(os.pathsep)
         )
         if any(in_path):
-            laszip_binary = binary
-            break
+            return binary
+
     else:
+        return None
+
+
+def _pass_through_laszip(stream, action="decompress"):
+    laszip_binary = find_laszip_executable()
+    if laszip_binary is None:
         raise FileNotFoundError("Could not find laszip executable")
 
     if action == "decompress":

pylas/lasdatas/base.py

@@ -126,7 +126,13 @@ def __getattr__(self, item):
     def __setattr__(self, key, value):
         """ This is called on every access to an attribute of the instance.
         Again we use this to forward the call the the points record
+
         But this time checking if the key is actually a dimension name
+        so that an error is raised if the user tries to set a valid
+        LAS dimension even if it is not present in the field.
+        eg: user tries to set the red field of a file with point format 0:
+        an error is raised
+
         """
         if key in dims.DIMENSIONS or key in self.points_data.all_dimensions_names:
             self.points_data[key] = value

pylastests/test_extrabytes.py

@@ -2,6 +2,8 @@
 import pytest
 
 import pylas
+from pylas.compression import find_laszip_executable
+
 from pylastests.test_common import (
     test1_4_las,
     extra_bytes_las,
@@ -10,8 +12,14 @@
     simple_las,
 )
 
+extra_bytes_files = [extra_bytes_las]
+# Because currently lazperf cannot decompress 1.4 file with extra dim
+# and Travis CI doesn't have laszip installed
+if find_laszip_executable() is not None:
+    extra_bytes_files.append(extra_bytes_laz)
+
 
-@pytest.fixture(params=[extra_bytes_las, extra_bytes_laz])
+@pytest.fixture(params=extra_bytes_files)
 def extrab_las(request):
     return pylas.read(request.param)
 
@@ -50,10 +58,10 @@ def test_add_extra_bytes(las1_4):
     las1_4.test_array[:, 1] = 2.2
     las1_4.test_array[:, 2] = 333.6
 
-    assert np.alltrue(las1_4.points_data['test_dim'] == 150)
-    assert np.allclose(las1_4.points_data['test_array'][:, 0], 1.1)
-    assert np.allclose(las1_4.points_data['test_array'][:, 1], 2.2)
-    assert np.allclose(las1_4.points_data['test_array'][:, 2], 333.6)
+    assert np.alltrue(las1_4.points_data["test_dim"] == 150)
+    assert np.allclose(las1_4.points_data["test_array"][:, 0], 1.1)
+    assert np.allclose(las1_4.points_data["test_array"][:, 1], 2.2)
+    assert np.allclose(las1_4.points_data["test_array"][:, 2], 333.6)
 
     las1_4 = write_then_read_again(las1_4)
 
@@ -66,7 +74,7 @@ def test_add_extra_bytes(las1_4):
 def test_extra_bytes_well_saved(extrab_las):
     extrab_las.Time = np.zeros_like(extrab_las.Time)
 
-    assert np.alltrue(extrab_las.points_data['Time'] == 0)
+    assert np.alltrue(extrab_las.points_data["Time"] == 0)
 
     extrab_las = write_then_read_again(extrab_las)