fix(ceb-templating-literal): attribute name with matching value shoul…

…d not be handled as boolean
tmorin · Nov 10, 2021 · 8b37edf · 8b37edf
1 parent 3406fe5
commit 8b37edf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/packages/ceb-templating-literal/src/literal.attribute.spec.ts b/packages/ceb-templating-literal/src/literal.attribute.spec.ts
@@ -11,14 +11,14 @@ describe("literal/attribute", function () {
     })
     it("should parse attributes", function () {
         const value = 1
-        const template = html`<p><input required disabled="" type="number" value="${value}" ></p>`
+        const template = html`<p><input name="name" required disabled="" type="number" value="${value}"></p>`
         template.render(el)
-        expect(el.innerHTML).to.be.eq(`<p><input required="" disabled="" type="number" value="1"></p>`)
+        expect(el.innerHTML).to.be.eq(`<p><input name="name" required="" disabled="" type="number" value="1"></p>`)
     })
     it("should parse complex attributes", function () {
         const foo = "foo"
         const bar = "bar"
-        const template = html`<p><input type="text" name="${foo}" value="before ${bar} after" ></p>`
+        const template = html`<p><input type="text" name="${foo}" value="before ${bar} after"></p>`
         template.render(el)
         expect(el.innerHTML).to.be.eq(`<p><input type="text" name="foo" value="before bar after"></p>`)
     })

diff --git a/packages/ceb-templating-literal/src/literal.complex.spec.ts b/packages/ceb-templating-literal/src/literal.complex.spec.ts
@@ -20,7 +20,7 @@ describe("literal/complex", function () {
         template.render(el)
         expect(el.innerHTML).to.be.eq(`<ul><li>header</li><li>itemA</li><li>itemB</li><li>itemC</li><li>footer</li></ul>`)
     })
-    it.only("should handle a bulma card", function () {
+    it("should handle a bulma card", function () {
         let cardName = "The name of the card"
         let cardDescription = "The description of the card."
         const template = html`

diff --git a/packages/ceb-templating-literal/src/literal.ts b/packages/ceb-templating-literal/src/literal.ts
@@ -80,8 +80,7 @@ function generateParameters(tagAttrs: Array<Attribute> = [], args: Array<any>):
                 })
             }
         } else {
-            const sanitizedAttrValue = value === attrName ? "" : value
-            attributes.push([attrName, sanitizedAttrValue])
+            attributes.push([attrName, value])
         }
     })
     return {attributes, properties, options}