feat(s3): new parameter "format" for png images #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutin1987
reviewed
Feb 8, 2018
| @@ -52,10 +52,11 @@ export default class StorageS3 { | |||
| return this; | |||
| } | |||
|
|
|||
| async transform(fromKey, toKey, transform = sharp().jpeg()) { | |||
| async transform(fromKey, toKey, transform = sharp(), format) { | |||
There was a problem hiding this comment.
args 不應該 required, required, option, required
yutin1987
suggested changes
Feb 9, 2018
| @@ -52,10 +52,11 @@ export default class StorageS3 { | |||
| return this; | |||
| } | |||
|
|
|||
| async transform(fromKey, toKey, transform = sharp().jpeg()) { | |||
| async transform(fromKey, toKey, format, transform = sharp()) { | |||
There was a problem hiding this comment.
transform() 不需要，format 可以維持 transform 的彈性
| await this.s3.copyObject({ CopySource: `${this.bucket}/uploader/${key}`, Key: `media/${toKey}` }).promise(); | ||
| await this.transform(`media/${toKey}`, `media/${toKey}_cover`); | ||
| await this.transform(`media/${toKey}`, `media/${toKey}_cover`, format); |
There was a problem hiding this comment.
await this.transform(media/${toKey}, media/${toKey}_cover, toFormat(sharp(), format));
| const cacheName = `cache/${key}_cover_${[width, height].join('x')}`; | ||
|
|
||
| try { | ||
| await this.s3.headObject({ Key: cacheName }).promise(); | ||
| } catch (e) { | ||
| await this.transform(`media/${key}_cover`, cacheName, sharp().resize(width, height).jpeg()); | ||
| await this.transform(`media/${key}_cover`, cacheName, format, sharp().resize(width, height)); |
There was a problem hiding this comment.
await this.transform(media/${key}_cover, cacheName, toFormat(sharp().resize(width, height), format));
wl00887404
force-pushed
the
pngQAQ
branch
2 times, most recently
from
4829dfb
to
5a4056c
Compare
yutin1987
approved these changes
Feb 12, 2018
|
@wl00887404 測試需要可以 pass |
1 similar comment
yutin1987
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmotx/tickets#42
Related: https://github.com/tmotx/platform/pull/367