Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer Tracing #147

Merged
merged 1 commit into from
Apr 22, 2013
Merged

Clearer Tracing #147

merged 1 commit into from
Apr 22, 2013

Conversation

neocotic
Copy link
Member

Trace logging similar to the following;

Error
    at isProtectedPage (chrome-extension://dcjnfaoifoefmnbhhlbppaebgnccfddf/lib/background.js:460:9)
    at Object.callback (chrome-extension://dcjnfaoifoefmnbhhlbppaebgnccfddf/lib/background.js:346:20)
    at Object.chromeHidden.handleResponse (sendRequest:49:24)

Can be confusing because of the "Error" heading. This PR replaces this heading with "Trace". For example;

Trace
    at isProtectedPage (chrome-extension://dcjnfaoifoefmnbhhlbppaebgnccfddf/lib/background.js:460:9)
    at Object.callback (chrome-extension://dcjnfaoifoefmnbhhlbppaebgnccfddf/lib/background.js:346:20)
    at Object.chromeHidden.handleResponse (sendRequest:49:24)

Simple change but effective.

@ghost ghost assigned neocotic Apr 22, 2013
neocotic added a commit that referenced this pull request Apr 22, 2013
@neocotic
Merge pull request #147 from neocotic/clearer-tracing
6bc9225 
Clearer Tracing
@neocotic neocotic merged commit 6bc9225 into wip-1.2.1 Apr 22, 2013
@neocotic neocotic deleted the clearer-tracing branch April 22, 2013 11:15
@neocotic neocotic mentioned this pull request Apr 22, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@neocotic neocotic

Labels
enhancement
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
1 participant
@neocotic