Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to tough-cookie@1.1.0 #1112

Closed
domenic opened this issue Apr 29, 2015 · 1 comment
Closed

Update to tough-cookie@1.1.0 #1112

domenic opened this issue Apr 29, 2015 · 1 comment

Comments

@domenic
Copy link
Member

domenic commented Apr 29, 2015

I tried but it broke a bunch of tests: https://travis-ci.org/tmpvar/jsdom/jobs/60607718#L373

@inikulin any ideas?
@inikulin
Copy link
Contributor

@domenic This is due to salesforce/tough-cookie#36. Previously, localhost was resolved as public suffix, which is incorrect. Need to fix tests on our side. I'll issue a PR.

@domenic domenic closed this as completed in d18d611 May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inikulin @domenic