Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to eslint@2.0.0 #1446

Closed
deckar01 opened this issue Apr 10, 2016 · 6 comments
Closed

Migrate to eslint@2.0.0 #1446

deckar01 opened this issue Apr 10, 2016 · 6 comments

Comments

@deckar01
Copy link

When lo1tuma/eslint-plugin-mocha#57 is fixed it will depend on eslint@2.0.0 unless they release a patch for 1.1.

My initial test indicated that simply resolving the deprecated rules did not cause eslint to pass.

@domenic
Copy link
Member

domenic commented Apr 10, 2016

I gave this a try. Blocked on eslint/eslint#5661.

@deckar01
Copy link
Author

There seems to be quite a few places where the config file had a rule set to "error", but there were violations getting missed before 2.0.0.

@domenic
Copy link
Member

domenic commented Apr 10, 2016

Yeah, probably the whole-program analysis thing they introduced. I started in the https://github.com/tmpvar/jsdom/tree/eslint-2 branch but didn't finish, and probably won't bother until they fix the quotes rule anyway.

@deckar01
Copy link
Author

It would be nice if --fix was implemented in more of the core rules.

@domenic domenic closed this as completed in 93dd663 May 1, 2016
@deckar01
Copy link
Author

deckar01 commented May 2, 2016

I had a feeling this was going to cause a lot of changes.

When I originally looked at this, the html file script-languages-02.html gave me trouble, because it was es5. I tried configuring an eslint hint to handle it correctly, but it did not seem to work. I noticed you set the jslint hint to ignore that script, which seems reasonable for test data, just curious what your thoughts were.

@domenic
Copy link
Member

domenic commented May 2, 2016

Since that test is just a tweaked version of an existing web platform test, it makes sense to ignore it. All the other tests get linted though.

nhunzaker pushed a commit to nhunzaker/jsdom that referenced this issue Dec 22, 2016
Closes jsdom#1446. Apparently a lot of cases were not previously caught, and 2.x's "whole-program analysis" is able to catch them, so we fix them here, in addition to enforcing newly-introduced rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants