Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLDivElement.toString() now returns [object HTMLDivElement] as a browser would. #970

Closed
wants to merge 2 commits into from

Conversation

AVGP
Copy link

@AVGP AVGP commented Dec 4, 2014

This fixes #766 but I'm not sure if I implemented it properly

@domenic
Copy link
Member

domenic commented Dec 5, 2014

Nice, thanks! Merged as e106d62. As you may have seen from previous discussions, eventually (maybe when iojs ships!) we will get a V8 that's up to date and has support for Symbol.toStringTag which will give us a nicer way to do all this. But until then these kind of spot fixes are great :).

@domenic domenic closed this Dec 5, 2014
@AVGP
Copy link
Author

AVGP commented Dec 5, 2014

Yeah, I'm aware of that - I just wanted to fix the nuisances quickly to fill in until we've got the latest and greatest V8 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toString() returns incorrectly under jsdom
2 participants