Textareas not having prefilled values when using weld to serve HTML from node.js & jsdom #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changed handling of textarea to use textContent. However, Opera ignores child text nodes when inserting textarea elements back into the document, so we have to still use value for Opera...
heapwolf
pushed a commit
that referenced
this pull request
Dec 24, 2011
Textareas not having prefilled values when using weld to serve HTML from node.js & jsdom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serving textarea elements from node.js using weld and jsdom, I was getting the value as an attribute on the textarea instead of as text content. This attribute is ignored by browsers getting served html from node.js.
This commit changed handling of textarea to use .textContent instead of .value. Opera ignores the child text nodes resulting from using .textContent while the textarea isn't in the document tree. To work around this, .value is still used for Opera.