Add solar production data for Croatia #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaCh
force-pushed
the
issue-1966
branch
2 times, most recently
from
36c6fa9
to
4f20116
Compare
|
@martincollignon could you please review this PR? |
corradio
requested changes
Sep 30, 2019
systemcatch
requested changes
Oct 1, 2019
There was a problem hiding this comment.
Hey @OlgaCh thanks for the PR, can you post the output from the HOPS parser?
|
Updated PR to address requested changes. Also noticed that in some cases data file with the solar data estimation may be not available for the current date since being updated with the delay. |
|
@corradio @systemcatch kindly check updated pr. |
corradio
approved these changes
Oct 2, 2019
systemcatch
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1966
Updates HOPS parser with the additional data source with the estimated power production by solar panels: https://www.hrote.hr/planning-electricity-production-for-the-eco-balance-group