Address CRAN Feedback 3/20 (#17)

* Remove don't test and drop to 1 observation

* Update CRAN comments

R/edina.R

@@ -110,7 +110,7 @@ new_edina_summary = function(edina, model_fit, alpha) {
 #' set.seed(1512)
 #'
 #' # Setup data simulation parameters
-#' N = 15   # Number of Examinees / Subjects
+#' N = 1    # Number of Examinees / Subjects
 #' J = 10   # Number of Items
 #' K = 2    # Number of Skills / Attributes
 #'
@@ -131,7 +131,6 @@ new_edina_summary = function(edina, model_fit, alpha) {
 #' # Simulate items under the DINA model
 #' items_dina = simcdm::sim_dina_items(subject_alphas, Q, ss, gs)
 #'
-#' \donttest{
 #' # Compute the edina model
 #' edina_model = edina(items_dina, k = K)
 #'
@@ -141,7 +140,6 @@ new_edina_summary = function(edina, model_fit, alpha) {
 #' # Provide a summary overview
 #' summary(edina_model)
 #' }
-#' }
 #'
 edina = function(data, k = 3, burnin = 10000, chain_length = 20000){
 

cran-comments.md

@@ -13,7 +13,7 @@
 **Remarks**
 
 - The following misspelled words are due to the shortening of the list of authors
-  to "et al.".
+  to "et al." and the method acronym.
 
 > Possibly mis-spelled words in DESCRIPTION:
 > EDINA (20:42)
@@ -22,7 +22,8 @@
 
 - From the last submission:
 
-- We have made sure all examples are using `donttest` if they exceed the
-  5 second execution threshold.
-- Each function now also has a `Value` field that describes what is returned or
-  what side-effect occurs. 
+- We've removed the `donttest` portion for `edina()` by dropping the number of
+  observations calculated to 1. We cannot remove the donttest option for 
+  `auto_edina()` as it requires at least 10 seconds with 2 different matrices
+  being estimated. 
+