Deep linking 2 #24
Open
Deep linking 2 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this should be a clean pull request for the deep linking bit.
Still working from the account list activity, see my comment from the other thread:
I know View intents can't be catched by broadcastreceivers, can try with an intentservice, but the main reason why I used AccountList is UI related: if the first screen we land in is the issue, there's no obvious way to go back to the account list, if you close the app and open it again you land in the issue unless you kill it first.Perhaps we can use a service and then hijack the back button in IssueActivity.homeSelected(), but I don't like it