Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use q{} for _status_message so message can contain a single quote #4

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

timbunce
Copy link

Fixes #3

@tmueller tmueller merged commit 87a53d6 into tmueller:master Jul 18, 2018
@tmueller
Copy link
Owner

Thanks a lot for your submission. I merged your PR and HTTP::Exception was released just now with your additions :)

Although I could not recreate the issue you described in Issue #3, I kept your way of escaping the quote in "I'm a teapot" using q{}. I tried to sanitize the qoute with s/'/\'/ before, but obviously that didn't work and was not as ellegant as your solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP::Exception silently broken by http status 418 "'I'm a teapot'"!
2 participants