Add resurrect-limit-shell-history option #307
Conversation
This patch adds a new tmux-ressurect option, resurrect-limit-shell-history, to limit the frequency of saving shell history to once per day. The motivation of this option is that otherwise resurrect is run much more frequently (e.g., ~ every 15 minutes), and saving the history spams the console (saving other state does not...). Spamming the console ~once per day, while still saving history, seems like a reasonable tradeoff---hence this patch.
|
Hey, I'm sorry you invested time and effort in making this work, but "restore shell history" is long-time unsupported. I unofficially mentioned it's unsupported and deprecated in issues. My bad for not deprecating it officially - I intend to that that this week #308 |
|
No need to apologize. After downloading the plugin 5 days ago and immediately turning on the feature, I definitely think that deprecating it is an improvement over the existing behavior. I do think that the patch I posted seems like a worthwhile tradeoff for my typical usage, where I have my machine for months before reboot. With this patch, the feature only spams the console once per day, around midnight, which isn't so bad. But that could still be confusing/annoying to folks... Regardless, please don't worry that I spent time on this patch. I only worked on it for a couple of hours (no big deal). Thanks a lot for maintaining this really cool plugin! |
This patch adds a new tmux-ressurect option,
resurrect-limit-shell-history, to limit the frequency of saving shell
history to once per day. The motivation of this option is that otherwise
resurrect is run much more frequently (e.g., ~ every 15 minutes), and
saving the history spams the console (saving other state does not...).
Spamming the console ~once per day, while still saving history, seems
like a reasonable tradeoff---hence this patch.