only add -l when default_shell is bash #320
Conversation
scripts/restore.sh
Outdated
| @@ -100,7 +100,11 @@ tmux_socket() { | |||
| # tmux server each time. | |||
| cache_tmux_default_command() { | |||
| local default_shell="$(get_tmux_option "default-shell" "")" | |||
| export TMUX_DEFAULT_COMMAND="$(get_tmux_option "default-command" "-l $default_shell")" | |||
| local opt="" | |||
| if [ "`basename $default_shell`"x == "bash"x ]; then | |||
There was a problem hiding this comment.
Can we use $(basename $default_shell) instead of backticks? Btw. what's x at the end of the strings used for?
There was a problem hiding this comment.
Can we use $(basename $default_shell) instead of backticks?
Sure.
Btw. what's x at the end of the strings used for?
It's an old habit to avoid test errors (unary operator issues), if one side is empty or undefined.
Theoretically default_shell should never be empty, also the double-quotes should prevent the error as well, but it all depends on the bash version and it doesn't hurt to be on the safe side.
There was a problem hiding this comment.
If you want I can remove the x.
|
I suspect you squash the commits anyway. If not, I can create only one commit. Please let me know. |
|
This PR is merged via 1160c1d, I've removed the |
see #94 (comment)