Add yank on MouseDragEnd1Pane #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docwhat
suggested changes
Jun 3, 2018
scripts/helpers.sh
Outdated
| @@ -121,6 +135,7 @@ command_exists() { | |||
| } | |||
|
|
|||
| clipboard_copy_command() { | |||
| local mouse="$1" | |||
There was a problem hiding this comment.
Change that to local mouse="${1:-false}" to preserve previous callers.
|
|
||
| yank_with_mouse_default="on" | ||
| yank_with_mouse_option="@yank_with_mouse" | ||
|
|
There was a problem hiding this comment.
I would appreciate it if you could add a description of these to the README.md.
|
@docwhat thanks for the feedback, I made the requested changes and updated mouse documentation. |
docwhat
approved these changes
Jun 11, 2018
|
I would really love to see getting this merged - anything holding it up? |
|
I just stumbled across this PR, I second the desire to get this merged and offer to rebase it to get it merged if @docwhat is still interested. In the meantime, I have the following workaround to share: The above binding was reverse engineered from what this PR does under the hood |
docwhat
approved these changes
Dec 4, 2018
docwhat
added a commit
that referenced
this pull request
Dec 4, 2018
- Ran `shfmt` on shell code. - Fixed ordering of `xclip` and `xsel`. Issue #109
|
Thanks for reminding me. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically expands on some of the removed code from #104 so that:
@yank_selection_mousecontrols the selection on Linux, defaulting to PRIMARY@yank_with_mousetooffwill disable these changes