Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on calling Server.attached_sessions #341

Closed

Conversation

Timoses
Copy link
Contributor

@Timoses Timoses commented Oct 23, 2021

fixes #180

@tony
Copy link
Member

tony commented Oct 30, 2021

@Timoses Can you rebase this and #342 so tests run? Thank you!

@Timoses Timoses force-pushed the bugfix/fix-#180-attached-sessions branch from d902885 to 7198957 Compare October 30, 2021 15:24
@Timoses
Copy link
Contributor Author

Timoses commented Oct 30, 2021

@tony : Done ; )

@tony
Copy link
Member

tony commented Oct 30, 2021

@Timoses Thank you!

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #341 (7198957) into master (714261b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files          16       16           
  Lines        1515     1515           
=======================================
  Hits         1319     1319           
  Misses        196      196           
Impacted Files Coverage Δ
libtmux/server.py 79.19% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714261b...7198957. Read the comment docs.

@tony tony closed this in #342 Oct 30, 2021
@tony
Copy link
Member

tony commented Oct 30, 2021

Merged via #342 @ 7198957,

Thank you @Timoses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug in attached_sessions() method
2 participants