Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy: Strict annotations #383

Merged
merged 10 commits into from Aug 5, 2022
Merged

Mypy: Strict annotations #383

merged 10 commits into from Aug 5, 2022

Conversation

tony
Copy link
Member

@tony tony commented Jul 31, 2022

#360

Compare to libvcs: vcs-python/libvcs#390

@tony tony force-pushed the strict-mypy branch 3 times, most recently from 14aaffd to b95b438 Compare July 31, 2022 17:44
@tony tony mentioned this pull request Jul 31, 2022
tony added a commit that referenced this pull request Jul 31, 2022
@tony tony force-pushed the strict-mypy branch 4 times, most recently from 0662e51 to 2785a7c Compare July 31, 2022 18:52
tony added a commit that referenced this pull request Jul 31, 2022
These will make it much easier to reason about dependent relations

Not as thorough as #383 will be
@tony tony force-pushed the strict-mypy branch 8 times, most recently from bbb4733 to e81195e Compare August 5, 2022 00:35
tony added a commit that referenced this pull request Aug 5, 2022
@tony tony force-pushed the strict-mypy branch 2 times, most recently from a2b196b to dfcc251 Compare August 5, 2022 00:40
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #383 (1b4fe96) into master (1b4fe96) will not change coverage.
The diff coverage is n/a.

❗ Current head 1b4fe96 differs from pull request most recent head 1eb43c1. Consider uploading reports for the commit 1eb43c1 to get more accurate results

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files          16       16           
  Lines        1618     1618           
=======================================
  Hits         1425     1425           
  Misses        193      193           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tony tony force-pushed the strict-mypy branch 3 times, most recently from 7189c90 to eae566d Compare August 5, 2022 00:57
@tony tony merged commit 6cfa6d9 into master Aug 5, 2022
@tony tony deleted the strict-mypy branch August 5, 2022 01:09
tony added a commit that referenced this pull request Aug 5, 2022
tony added a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant