Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible navigator related fixes #523

Merged
merged 20 commits into from Feb 15, 2024
Merged

Ansible navigator related fixes #523

merged 20 commits into from Feb 15, 2024

Conversation

tony
Copy link
Member

@tony tony commented Feb 13, 2024

Resolves #468.

Changes

Breaking changes

  • Session.new_window() + Window.split_window(): No longer attach by default. Pass attach=True for the old behavior.
  • Pane.resize_pane renamed to Pane.resize()

Window.resize_window(): Added

If Pane.resize_pane() didn't work before, try resizing the window.

Pane.resize(): Arguments added

Server.panes: Fix listing of panes

Would list only panes in attached session, rather than all in a server.

Window.refresh() and Pane.refresh(): Refresh more underlying state

Obj._refresh: Allow passing args

e.g. -a (all) to list-panes and list-windows

See also

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (e67c5a9) 89.10% compared to head (a5980cf) 88.76%.

Files Patch % Lines
src/libtmux/pane.py 55.88% 8 Missing and 7 partials ⚠️
src/libtmux/window.py 64.00% 4 Missing and 5 partials ⚠️
src/libtmux/exc.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   89.10%   88.76%   -0.35%     
==========================================
  Files          36       37       +1     
  Lines        3562     3685     +123     
  Branches      501      526      +25     
==========================================
+ Hits         3174     3271      +97     
- Misses        267      281      +14     
- Partials      121      133      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony merged commit 48ea20b into master Feb 15, 2024
25 checks passed
@tony tony deleted the fix-ansible-navigator branch February 15, 2024 00:55
tony added a commit that referenced this pull request Feb 15, 2024
tony added a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest-xdist issues when libtmux > v0.16.1
1 participant