Add simple python3 compatibility fix #119
Conversation
| @@ -22,7 +22,11 @@ | |||
| install_reqs += ['argparse'] | |||
| tests_reqs += ['unittest2'] | |||
|
|
|||
| readme = open('README.rst').read() | |||
| if sys.version_info[0] == 3: | |||
There was a problem hiding this comment.
Better check for >2. Assume that a future Python 4 is compatible unless stated otherwise.
To assume that future python versions will be compatible with this syntax. Suggested by: ThiefMaster
|
This is a python fix for py-tmuxp @ https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201564. @mexicarne Thank you. Want to update it to use |
|
Yes, I just committed the updated check as was suggested. |
|
@mexicarne Solid. Let's wait for tests to pass, then we'll update the changelog, bump the version and post on pypi. 😄 |
Add simple python3 compatibility fix
|
@tony So, all set. Please add some comment with your maintainer approval to bugzilla ticket after you done updating on pypi, so I can update it in FreeBSD ports. Thanks. |
|
@mexicarne not applicable here anymore since the PR is already merged, but generally it's better to amend and force-push simple improvements on a PR instead of adding a separate commit |
|
@ThiefMaster will do next time, thanks. |
This resolves the package build with python 3.x