Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when build with --enable-utempter, does not call utempter_add_record #2022

Closed
pschellenbach opened this issue Dec 17, 2019 · 2 comments
Closed

when build with --enable-utempter, does not call utempter_add_record #2022

pschellenbach opened this issue Dec 17, 2019 · 2 comments

Comments

@pschellenbach
Copy link

when build with --enable-utempter, does not call utempter_add_record

Sorry, I am not a tmux user, but was browsing the code for examples of how to use utempter to update utmp file and discovered possible bug in current tmux version.

In commit 5ece38 the call to utempter_add_record was removed however the calls to utempter_remove_record remain.

This code was previously in window_pane_spawn:

#ifdef HAVE_UTEMPTER
	xsnprintf(s, sizeof s, "tmux(%lu).%%%u", (long) getpid(), wp->id);
	utempter_add_record(wp->fd, s);
	kill(getpid(), SIGCHLD);
#endif

Looks like it should now be inserted after the label 'complete' in spawn.c.

Required information

Please provide the following information:
@nicm
Copy link
Member

nicm commented Dec 18, 2019

Shows how many people care about utempter, eh. Fixed now, thanks!

@nicm nicm closed this as completed Dec 18, 2019
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 19, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
5a4ad91 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 19, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
34d3589 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 19, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
074dfdd 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 20, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
6d2c1e7 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 20, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
8d7030d 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 21, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
a7b706a 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 22, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
cd22401 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 23, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
eb4d0a5 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 23, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
de47f83 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 25, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
73fbbd3 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 27, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
a11d244 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 28, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
5722d3b 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Jan 31, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
86a4c95 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 1, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
e1e8c0c 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 2, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
b402fe2 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 3, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
cdce327 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 4, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
a018e3d 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 4, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
7f71803 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 5, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
5e45501 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 6, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
db22d79 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 7, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
bf66a26 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 8, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
89287e9 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 10, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
345f5fd 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
yasuhirokimura pushed a commit to yasuhirokimura/freebsd-ports that referenced this issue Feb 11, 2020
sysutils/tmux: Add upstream patch to fix bug that utempter doesn't wo…
a0c52dc 
…rk as is expected

Add upstream patch to fix bug that utempter doesn't work as is
expected.

Reference:
tmux/tmux#2022
tmux/tmux@54efe33
@lock
Copy link

lock bot commented Mar 11, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicm @pschellenbach