-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.1a questions and comments #2186
Comments
I'm on tmux 3.1a on ArchLinux, first time I try tmux too, while in and while writing this, due to adding the above
Therefore the question still stands: how to make Ctrl+RightArrow work properly in a vim running under tmux?(it's supposed to skip a word) Note that outside of 'vim'(ie. at command prompt) it works as intended. Another thing: I've to use either |
|
sorry for being unclear, the I guess ignore this one(can't repro. anymore)There was another issue which I didn't mention which got fixed by `set-option -s escape-time 0`, but without it: pressing&releasing Esc and then pressing a number in `mc` would have no effect (though `Esc,1` would sometimes rarely produce an F1, but I couldn't reproduce the condition when it would happen) This is odd, now I cannot reproduce this anymore, that is, without `escape-time` set at all.Another question: when I press Another question: How to scroll with mouse wheel inside vim(which has
|
given that info, thank you, I'm able to work around it via
|
I suspect mc is doing the same, you will probably need to configure it manually or ask the mc developers. less does not support the mouse until very new versions which have a vim should support the mouse, are you sure you are using the right |
I have added a much simpler example of enabling |
Anyone having problems with the 🦠 emoji? tmux set -g status-right "🦠" This messes up my tmux status and tmux starts to behave strangely |
Most likely your terminal and tmux disagree about the width of this Unicode codepoint. Perhaps try 1) upgrading your terminal 2) a different terminal 3) a different emoji 4) building tmux with |
It's not something important to me (obviously), just wanted to point that out because it looked like a regression, since it was working before |
Please show me tmux-server*.log from doing this:
|
tmux is unable to establish the width of this codepoint (your system If I print this symbol in iTerm2 and alacritty, it appears to be width 2. Try this outside tmux to see:
Are you absolutely sure you didn't upgrade anything but tmux since this was working? Your operating system, terminal, font? Are you certain you weren't using an older tmux built with utf8proc and now have a tmux built without it? |
If you could build a tmux 3.0a or whatever older version you were using, verify it still works, then send me a similar server log file, it would be helpful. |
If I build tmux with |
I never built it myself before, I always used Homebrew(aur on linux) to install it. I don't know what changed from my latest installation that caused this. Thank you so much for the support. I recently spent two days without tmux (not related to this issue) and noticed how integral it is on my workflow, between running tests, scripts on servers and bootstrapping "workspaces" with tmuxinator, I just don't leave tmux anymore. Thank you for all the time and effort you put into it! |
Great stuff, thanks! |
A question from me too.
But I really want the old behavior. Is there a configuration option to return it - the part for the count not showing all matches? |
No, why do you want a count of all matches? |
Well, 1) it's difficult to see immediately when the search wraps around (I have to keep looking at the line numbers for that) and 2) what's the point in having matches count in just the viewport? I can literally count them. That's not useful information for me. I want to be able to know the total count - for statistics, for knowing where in the results is the last result, etc. I can't even begin to explain, it's so obvious for me that this is useful and what is in 3.1 isn't. 😄 |
1 is a good point, we can maybe show when the search wraps. I don't think 2 is useful, the purpose of searching is not to show statistics, tmux has always been unusual in showing a match count at all, neither emacs nor vi do, we might be best to remove it altogether. |
Yes, vim doesn't have it, but when I "grep" with vim I do have it. Having the total amount of results in a search is one of the two basic functionalities of a search - the other one being showing the results themselves. You had the feature. I think it's pretty important. Why don't you just return it with some option (disabled by default)? Best of both worlds. Pretty please. 😃 |
Because if we add an option for every thing that one person likes or doesn't like without very good reasons, we end up with an unmaintainable list of a million options that only one person ever uses (I have been there before!). This was changed for a good reason - having regex search is something useful to many people and the fact is that lots of them increase their There are things we could do, for example we could count for up to a short time period instead of only the visible screen, which would mean you would get a full count if your history was short and your search term simple enough. But this is not entirely trivial to implement and I'm not convinced - I don't really understand why you want it, it doesn't seem like a basic function of search to me at all. Neither of the two applications we take as a model for copy mode (emacs or vi) offers it when searching interactively. What do you use it that adding "search wrapped" text wouldn't show? How do you manage it in vi when |
Let me take a look and see how hard a 0.5 second timeout or something would actually be... |
We already have a 10 second timeout that we probably don't need anymore so we could probably just reduce that and just hide the match count when it is hit. |
That's a good question. But keep in mind that Vim and tmux are used for different things. With Vim I edit my source code, for example. With tmux I run tests. It's not that useful, for example, when I'm editing a file, to know how many times "foo" is present. However, when I'm running my tests or some other command with output on the terminal, I would like to know how many times "Exception" has been displayed. Just an example of the top of my head. Another thing - I never, until you mentioned it, even realized that I've been using Vim without results count (but I do have them when grepping with Vim as I mentioned which is very useful). But I noticed the change in tmux behavior pretty much immediately. It's that important for me. And I read the release notes and noticed the change. So yes, Vim and tmux are used for different things and perhaps that's why they need somewhat different features here and there. Thank you for the discussion and the time you'll spend on trying to do something about it! |
Hmm OK that is reasonable, let me have a look. It is not trivial because we search from top to bottom not bottom to top but we might be able to do it. |
Try this please (against master) which will search the visible text then spend up to 100 ms searching the history entirely as well - if it finishes in less than 100 ms you will get a results count, otherwise you won't: tmux-search-count.diff.txt |
Actually, it would be better to do it the other way round - try the whole thing first. Hold on... |
Try this instead please: tmux-search-count-2.diff.txt |
This seems to work great! I would change 2 things - 1) if it doesn't finish in 100 ms just show the total count until that point with a plus sign for example - I'll try the second diff now. |
The second patch works fine too. Not sure what the difference is. I guess my two points are still valid for it too. Thanks again for your support! |
The difference is it doesn't search unnecessarily - if it managed to search everything in 100ms then there is no point in searching the visible text again. I'll look at (1). I want a short timeout because searching is repeated automatically a lot for example when you scroll. We could bump it to 250 ms probably without too much harm. I don't want an option for this. |
I can show 215+ results if we time out but not which result you are on because that result may not have been one of the 215 we found - the count is started from the top not from the cursor position. |
OK because it is a timeout the number found can jump around a lot so I just made it show 1000+, 100+ or 10+ instead if it times out otherwise it is just confusing. I also bumped the timeout to 200 ms and will see how it goes. The easiest way to make it timeout is to make a reasonably big history and then search for |
I've applied this so it is in master now, let me know if you see any problems. Thanks! |
Great, thanks a lot! |
EDIT: OK this is weird. I just deleted my Hi. Thanks for the great application. I have just upgraded from tmux 3.1 to 3.1a using brew and couldn't open tmux any more due to a crash. It exits and outputs weird text
Here is my configuration. I removed all the config but the error still happens
Here is the tmux-client.log |
@boris-petrov have you found a solution? I want to have the old behaviour as well. For me, it was the feature why I started using Tmux |
@evmorov - I've pinned my tmux version to |
@sondnm same problem as you, but find no reply here. I read this issue again and find this at the very begining:
So I exit my running tmux session, and it works again. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Ask or discuss any quick questions here about 3.1 or 3.1a only please.
Bug reports please open a new issue with full information, see CONTRIBUTING.
tmux 3.1a is a bug fix release of 3.1 which fixes an issue with iTerm2's tmux integration.
A major effort before this release has been improving the documentation outside the manual page, although it is still not complete. See the wiki here. Also see issue #2163 for minor documentation reports and comments.
The 3.1a CHANGES file is here.
allow-rename
option that can cause tmux to crash. tmux 3.1b will be released in due course to fix this.allow-rename
defaults to off.Note that using a 3.1 client and a running server of an older version may not work reliably. Make sure you restart tmux entirely after upgrading and that you are running the correct binary at all times.
tmux 3.1 now tries
~/.config/tmux/tmux.conf
if~/.tmux.conf
does not exist. If both exist, both will be loaded.$XDG_CONFIG_HOME/tmux/tmux.conf
will also be tried in tmux 3.2.The text was updated successfully, but these errors were encountered: