Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option "tmux_detached" for detach client #284

Closed
wants to merge 1 commit into from

Conversation

mvaraga
Copy link
Contributor

@mvaraga mvaraga commented Feb 13, 2015

This option specifies if tmux start with attached or detached state.
Start attached when "false" or option not defined, otherwise detached.
As requested in #191 #224

This option specifies if tmux start with attached or detached state.
Start attached when "false" or option not defined, otherwise detached.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 97.36% when pulling 5bb43ca on mvaraga:master into d081b6d on tmuxinator:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 97.36% when pulling 5bb43ca on mvaraga:master into d081b6d on tmuxinator:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 97.36% when pulling 5bb43ca on mvaraga:master into d081b6d on tmuxinator:master.

@maxmeyer
Copy link

@Soliah
Does it make sense to add a "detached"-option to start as well?

tmuxinator start <project> --detached

This way one could add it to a shell initscript.

tmuxinator start project_1 --detached
tmuxinator start project_2 --detached
tmuxinator start project_3 --detached
tmuxinator start project_4 --detached

Would love to see this merged.

@ghost
Copy link

ghost commented Feb 18, 2015

Command line flag would be great. Thor makes it relatively easy to add the option if you want to have a go @mvaraga?

@mvaraga
Copy link
Contributor Author

mvaraga commented Feb 20, 2015

I do it. Should I preserve option in project file and override it with start option. Or just start option?

@maxmeyer
Copy link

Personally I would expect that the --detach-option will override the configuration in the project config-file.

@ghost
Copy link

ghost commented Feb 20, 2015

Yes sounds good that the command line option takes precedence.

On 20 Feb 2015, at 8:36 pm, maxmeyer notifications@github.com wrote:

Personally I would expect that the --detach-option will override the configuration in the project config-file.


Reply to this email directly or view it on GitHub.

@paularmstrong
Copy link

This is great! Definitely a helpful addition.

@maxmeyer
Copy link

@mvaraga Any progress on that? ;-) Any help needed?

@ghost
Copy link

ghost commented Jun 4, 2015

Thinks #293 deals with this now. Can you please try and comment in that issue for followup.

@ghost ghost closed this Jun 4, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants