Add ability for pre_window commands to parse yaml arrays (as well as strings) #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpassis
changed the title
pre_window commands to parse yaml arrays (as well as strings)
J3RN
requested changes
Jan 27, 2017
| @@ -135,7 +135,8 @@ def pre_window | |||
| elsif pre_tab? | |||
| yaml["pre_tab"] | |||
| else | |||
| yaml["pre_window"] | |||
| pre_window = yaml["pre_window"] | |||
| pre_window.is_a?(Array) ? pre_window.join("; ") : pre_window | |||
There was a problem hiding this comment.
Since this will be the third time this logic is used in this file, we should probably break it out into a private method and throw it at the bottom of the class somewhere.
J3RN
requested changes
Jan 30, 2017
| @@ -135,17 +131,14 @@ def pre_window | |||
| elsif pre_tab? | |||
There was a problem hiding this comment.
I just noticed that there are several conditional branches in this method. While multiple commands don't make sense for rbenv or rvm, would you mind also adding a call to parsed_parameters here with yaml["pre_tab"]?
J3RN
approved these changes
Feb 2, 2017
|
@rpassis Thanks for making those changes! This LGTM 👍 I just wish I knew why Code Climate is so upset, but it won't tell me 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only
precommands accept yaml strings and arrays. This commit adds the ability forpre_windowcommands to also accept yaml strings and arrays.