Handle 'tmux master' version more gracefully #574
Conversation
Same diff as tmuxinator#545 with minor changes as discussed in that thread. Treats 'tmux master' as being arbitrarily high, and displays a deprecation warning to users attempting to run tmuxinator under 'tmux master'.
|
It occurs to me that I should link related issues in the commit message and changelog. I'll add that when I can. |
|
It also occurs to me that the warning should be printed for any unsupported version, not just |
There was a problem hiding this comment.
I have one, very small nitpick: would you mind capitalizing "you" at the start of the TMUX_MASTER_DEP_MSG deprecation message? (I'll open a separate issue about using consistent formatting in the others, e.g. PRE/POST_DEP_MSG.)
Otherwise, pending those changes you mentioned, this looks good to me!
- References relevant open issues in changelog. - Adds a list of supported tmux versions to the Tmuxinator module. - Generalizes deprecation warning to apply to all unsupported versions. - Removes 'master' from .travis.yml since it is not officially supported.
|
Comments addressed. Ideally I'd like |
|
@rglassett @adamstrickland @ethagnawl thanks for this! It solved the very problem I was having. I was wondering how you'd feel about having an option - environment variable? cli flag? -- to disable the warning? That way those using tmux master wouldn't have to hit 'enter' every time they fire up tmuxinator. |
|
👍, I think a |
Same diff as #545 with minor changes as discussed in that thread. Treats 'tmux master' as being arbitrarily high, and displays a deprecation warning to users attempting to run tmuxinator under 'tmux master'.