Merge pull request #44 from jkoeppeler/fix-off-by-one-assert

chp4: c_snippet: fix assert statement
tnballo · Jan 27, 2024 · e35cb62 · e35cb62
2 parents f86c855 + aa18fbe
commit e35cb62
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/code_snippets/chp4/c_snippets/spatial.c b/code_snippets/chp4/c_snippets/spatial.c
@@ -9,7 +9,7 @@ char* get_greeting() {
         return NULL;
     } else {
         strncpy(greeting, "Hello", 6);
-        assert(greeting[6] == '\0');
+        assert(greeting[5] == '\0');
         return greeting;
     }
 }

diff --git a/code_snippets/chp4/c_snippets/temporal.c b/code_snippets/chp4/c_snippets/temporal.c
@@ -9,7 +9,7 @@ char* get_greeting() {
         return NULL;
     } else {
         strncpy(greeting, "Hello", 6);
-        assert(greeting[6] == '\0');
+        assert(greeting[5] == '\0');
         return greeting;
     }
 }

diff --git a/src/chp1/about_the_team.md b/src/chp1/about_the_team.md
@@ -47,6 +47,7 @@ Listed alphabetically:
 * [humb1t](https://github.com/humb1t)
 * [jam1garner](https://github.com/jam1garner)
 * [jamesreprise](https://github.com/jamesreprise)
+* [jkoeppeler](https://github.com/jkoeppeler)
 * [kaylynn234](https://github.com/kaylynn234)
 * [LoganDark](https://github.com/LoganDark)
 * [Michcioperz](https://github.com/Michcioperz)

diff --git a/src/chp4/attack_1.md b/src/chp4/attack_1.md
@@ -102,7 +102,7 @@ char* get_greeting() {
         return NULL;
     } else {
         strncpy(greeting, "Hello", 6);
-        assert(greeting[6] == '\0');
+        assert(greeting[5] == '\0');
         return greeting;
     }
 }