Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some typos in chp2 #15

Merged
merged 5 commits into from Apr 30, 2022
Merged

Conversation

aelnona
Copy link
Contributor

@aelnona aelnona commented Apr 30, 2022

Changes "e.g. read the the value of it's target." of line 137 of static_asurance_1.md to "e.g. read the value of its target."

Removes duplicate "down" of "We broke down the C version down" in static_assurance_2.md

Alters ". Which" to ", which" in static_assurance_2.md

Minor grammatical fixes to dynamic_assurance_3.md

Changes "e.g. read the the value of it's target." of line 137 to "e.g. read the value of its target."
"the the" -> "the" 
"it's" -> "its"
@aelnona aelnona changed the title Fixes typos in pointer analysis case study (chp2) Fixes typos in chp2 Apr 30, 2022
Removes duplicate "down" of "We broke down the C version down"
Could also be "We broke the C version down" but I thought that "We broke down the C version" sounded slightly more natural
Alters "... its type system. Which ..." to "... its type system, which ..." in: "... the language itself, in its type system. Which implements a flavor ..." (line 200)

It may be better to have "... its type system. Which ..." instead become "... its type system. This type system ...", but I am uncertain if "Which" absolutely refers to the type system, so I've only suggested a minimal grammatical correction rather than a rewording, as per `CONTRIBUTING.md`
@aelnona aelnona changed the title Fixes typos in chp2 Fixes some typos in chp2 Apr 30, 2022
aelnona and others added 2 commits April 30, 2022 12:55
Minor fixes
"16 byte" to "16 bytes" (line 110)
"`rustls`[^RusTLS], pure-Rust TLS library" to "`rustls`[^RusTLS], a pure-Rust TLS library"
@tnballo
Copy link
Owner

tnballo commented Apr 30, 2022

I reverted the ", which" change since that one isn't a typo - but the rest definitely are!

Thank you for catching all of these and for contributing again! Really appreciate it 😃

@tnballo tnballo merged commit 20bf883 into tnballo:main Apr 30, 2022
@tnballo
Copy link
Owner

tnballo commented Apr 30, 2022

Oops, just now read your commit message about the "which" - I see what you mean about that being ambiguous. Will reword it for clarity, I'm certain others could have the same thought!

@aelnona
Copy link
Contributor Author

aelnona commented Apr 30, 2022

No problem - or rather, thank you for making this project in the first place; loving the book so far, it's really well written and easy to understand, can't wait for the finished book!
:D

tnballo added a commit that referenced this pull request Apr 30, 2022
@tnballo
Copy link
Owner

tnballo commented Apr 30, 2022

So glad you like it! I was inspired by some of the amazing free books out there, like the official Rust book and "Crafting Interpreters".

Currently working on Chp. 4 but it may take a while, between research/revisions and job stuff, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants