add support for XmlCDATA text #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mevljas, thank you very much for your contribution! I will need to spend a bit of time considering how we handle CDATA, because using the pre-existing |
|
Understandable. We could just create another annotation :) |
|
I'll continue using my fork for now because it covers my requirements. |
This was referenced Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
I've implemented support for extracting text from XmlCDATA children.
Current behavior
Currently only extracting text from XmlText children is supported.
New behavior
Now getText method returns both text from XmlText and XmlCDATA children. The text is also trimmed because XmlCDATA elements contain leading and trailing whitespace.
Additional context
I'm not sure if this is the correct way to handle this. Maybe we could add another method only for handling XmlCDATA children?