Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to export ActionHandler type from index #24

Closed
tnez opened this issue Jun 30, 2023 · 0 comments · Fixed by #25 or #22
Closed

Need to export ActionHandler type from index #24

tnez opened this issue Jun 30, 2023 · 0 comments · Fixed by #25 or #22

Comments

@tnez
Copy link
Owner

tnez commented Jun 30, 2023 •
edited

The documentation gives an example of doing something like this:

import { createAction, ActionHandler } from "@tnezdev/actions";

type Conetxt = {};
type Input = {};
type Output = {};

const handler: ActionHandler<Context, Input, Output> = () => {};

However, the ActionHandler type is not currently being exported. Fix is required.
@tnez tnez mentioned this issue Jun 30, 2023
Merged
@tnez tnez closed this as completed in #25 Jun 30, 2023
tnez added a commit that referenced this issue Jun 30, 2023
@tnez
fix: add missing type exports (#25)
9a7833e 
The documentation gives an example of doing something like this:

```ts
import { createAction } from "@tnezdev/actions";
import type { ActionHandler } from "@tnezdev/actions";

type Conetxt = {};
type Input = {};
type Output = {};

const handler: ActionHandler<Context, Input, Output> = () => {};
```

However, the `ActionHandler` type was not being exported before this
fix.

Closes #24
@github-actions github-actions bot mentioned this issue Jun 30, 2023
Merged
tnez pushed a commit that referenced this issue Jun 30, 2023
@github-actions
Version Packages (#22)
f266f72 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @tnezdev/actions@0.3.1

### Patch Changes

-   b17bfb8: Add license (`Apache 2.0`)
-   f48413d: Re-enable edge-environment for unit tests in CI (closes #6)
-   9a7833e: fix: add missing type exports (closes #24)

    The documentation gives an example of doing something like this:

    ```ts
    import { createAction } from "@tnezdev/actions";
    import type { ActionHandler } from "@tnezdev/actions";

    type Conetxt = {};
    type Input = {};
    type Output = {};

    const handler: ActionHandler<Context, Input, Output> = () => {};
    ```

However, the `ActionHandler` type was not being exported before this
fix.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing type exports tnez/actions
Version Packages tnez/actions
1 participant
@tnez