Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SessionIndex to sp-initiated logout request #197

Closed
wants to merge 2 commits into from

Conversation

franklinjjeng
Copy link
Contributor

Adding SessionIndex to sp-initiated logout request. Updating defaultLogoutRequestTemplate context to include: <samlp:SessionIndex>{SessionIndex}</samlp:SessionIndex>

Correcting flow.ts -> sp.createLogoutRequest example. user object should be using logoutNameID instead of email.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.75% when pulling d2d55f5 on franklinjjeng:master into 031cafd on tngan:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.75% when pulling d2d55f5 on franklinjjeng:master into 031cafd on tngan:master.

@franklinjjeng
Copy link
Contributor Author

Let me know if I was supposed to put a PR to a different branch or if you'd like to make SessionIndex appear conditionally if it's not always expected as it may cause issues.

@tngan
Copy link
Owner

tngan commented Aug 7, 2018

@franklinjjeng In accordance of section 3.7 of specification, session index is optional.

Our default template supposes to include required fields. You can use custom template to handle this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants