Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable strict null checks during compilation #260

Merged
merged 2 commits into from Apr 5, 2019
Merged

enable strict null checks during compilation #260

merged 2 commits into from Apr 5, 2019

Conversation

laverya
Copy link
Contributor

@laverya laverya commented Apr 4, 2019

No description provided.

@coveralls
Copy link

coveralls commented Apr 4, 2019 •
edited

Coverage Status

Coverage decreased (-0.1%) to 87.954% when pulling 5f9f590 on laverya:enable-strictNullChecks into 6ec7855 on tngan:master.

@laverya laverya changed the title [WIP] enable strict null checks during compilation enable strict null checks during compilation Apr 4, 2019
@laverya
Copy link
Contributor Author

laverya commented Apr 5, 2019

@tngan let me know if there's anything you're not happy with here!

@tngan
Copy link
Owner

tngan commented Apr 5, 2019

@laverya I will take a look soon, I like this setting.

@tngan tngan self-requested a review April 5, 2019 19:45
@tngan tngan merged commit 9d1d502 into tngan:master Apr 5, 2019
@laverya laverya deleted the enable-strictNullChecks branch April 5, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tngan tngan tngan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laverya @coveralls @tngan