Feature/Login Request Relay State #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanton7
reviewed
May 11, 2021
|
|
||
| const metadata: any = { idp: entity.idp.entityMeta, sp: entity.sp.entityMeta }; | ||
| const spSetting: any = entity.sp.entitySetting; | ||
| const relayState = entity.relayState ?? entity.sp.entitySetting.relayState; |
There was a problem hiding this comment.
Shouldn't this be relayState ??= spSetting.relayState;? I'm not sure how this even builds currently because you have relayState parameter there and const variable with same name.
|
I'm closing this because as of version 2.7.7 the issue I had is no longer occurring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for relayState when creating the SAML request using
createLoginRequest. This is essentially the same implementation that was done in #257 but without the other changes not related to relay state. This would make it easier to use relay state in a backwards compatible way.