Replace colors with @colors/colors #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running into the documented issue with colors when trying to run this tool: tnicola#165
tnicola
reviewed
Apr 26, 2023
There was a problem hiding this comment.
Thanks @rebeccaalpert for your contribution. And sorry for the late reply. Just one minor comment.
package-lock.json
Outdated
There was a problem hiding this comment.
This file should not change, the demo app is getting cypress-parallel through a link to the local library for development purposes.
|
All set @tnicola - I dropped that file in the new commit. |
tnicola
approved these changes
Apr 28, 2023
This was referenced Apr 28, 2023
|
Thanks!The change is landed in v 0.13.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into this documented issue with colors when trying to run this tool: #165.
This migrates the repo away from colors (which has some documented issues) and onto a potentially more stable alternative.