-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved reliability and some initial ci configuration (closes: #10, #17, #20, #25, #27, #28, #30) #48
Merged
tnicola
merged 12 commits into
tnicola:master
from
kristofferlind:improved-reliability-and-ci
Sep 10, 2021
Merged
Improved reliability and some initial ci configuration (closes: #10, #17, #20, #25, #27, #28, #30) #48
tnicola
merged 12 commits into
tnicola:master
from
kristofferlind:improved-reliability-and-ci
Sep 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* extract settings to it's own module * extract finding/distributing tests into test-suites module * extract processing methods into thread module * extract utility methods into it's own module * replace logbased communication with filebased communication * add bail and verbose options * glob pattern matching * staggered start to avoid xvfb race condition * always use orchestration reporter, run in parallel with passed in reporter * allow starting demo-app from root
* configure serve-and-test scripts * github actions configuration * configure runs-on for test job * execute for pr/pushes to master * test cy:run * test cy:parallel
…less of picked reporter
Hi! I'm trying out this library facing issue #17. Would it be possible to merge this? I'd love to try it out and see if it fixes my issue. Thanks! |
Would love to see this merged. issue #28 is a pretty big blocker for use of this package for our CI pipeline |
tnicola
approved these changes
Sep 10, 2021
@kristofferlind Thanks a lot for all the cleanup, feature implementation, CI and bug fixes 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes:
related issues:
#27 might also be related, the issue I saw with intermittent missing results was that the event fired correctly in the reporter, but was never picked up when reading the logs, switch to filebased communication should hopefully make it a bit more robust