Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved reliability and some initial ci configuration (closes: #10, #17, #20, #25, #27, #28, #30) #48

Merged
merged 12 commits into from
Sep 10, 2021

Conversation

kristofferlind
Copy link
Contributor

Overview of changes:

  • bail feature
  • glob pattern
  • fix xvfb race conditions with staggered start
  • replace logbased communication with filebased communication as a workaround for intermittent missing test results
  • add check to make sure no results are missing
  • removed reporting feature of orchestrator, now just pipes output to process
  • utilize cypress-multi-reporter so that results orchestration is always on
  • added some rudimentary CI

related issues:

#27 might also be related, the issue I saw with intermittent missing results was that the event fired correctly in the reporter, but was never picked up when reading the logs, switch to filebased communication should hopefully make it a bit more robust

kristofferlind and others added 12 commits June 29, 2021 15:31
* extract settings to it's own module

* extract finding/distributing tests into test-suites module

* extract processing methods into thread module

* extract utility methods into it's own module

* replace logbased communication with filebased communication

* add bail and verbose options

* glob pattern matching

* staggered start to avoid xvfb race condition

* always use orchestration reporter, run in parallel with passed in reporter

* allow starting demo-app from root
* configure serve-and-test scripts

* github actions configuration

* configure runs-on for test job

* execute for pr/pushes to master

* test cy:run

* test cy:parallel
@jtabalujan2
Copy link

Hi! I'm trying out this library facing issue #17. Would it be possible to merge this? I'd love to try it out and see if it fixes my issue.

Thanks!

@amcinerneynewf
Copy link

Would love to see this merged. issue #28 is a pretty big blocker for use of this package for our CI pipeline

@tnicola tnicola merged commit fd0dfc9 into tnicola:master Sep 10, 2021
@tnicola
Copy link
Owner

tnicola commented Sep 10, 2021

@kristofferlind Thanks a lot for all the cleanup, feature implementation, CI and bug fixes 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants