Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mono-repo support via reporterModulePath option #81

Merged
merged 2 commits into from
Jan 28, 2022
Merged

feat: add mono-repo support via reporterModulePath option #81

merged 2 commits into from
Jan 28, 2022

Conversation

joshuajtward
Copy link
Contributor

@joshuajtward joshuajtward commented Jan 24, 2022

A small, hopefully effective config option which allows the module path for cypress-multi-reporters to be overwritten . In a mono-repo it might be necessary to pass something like ../../../node_modules/cypress-multi-reporters

Usage: add the argument -n ${path to your modules folder} to your CLI command or script

@joshuajtward joshuajtward marked this pull request as ready for review January 24, 2022 11:54
@tnicola
Copy link
Owner

tnicola commented Jan 25, 2022

Hi @joshuajtward , I think this is a good idea!Could you please change the argument alias?Since it conflicts with the "strictMode" one. Also, if you could update the doc in the README file that would be great too!Thanks!

@@ -36,6 +36,11 @@ const argv = yargs
type: 'string',
description: 'Reporter to pass to Cypress'
})
.option('reporterModulePath', {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the alias please

@joshuajtward
Copy link
Contributor Author

Thank @tnicola, updated to use n instead and added some info in the README. I hadn't noticed strictMode in the latest version 🤦

@tnicola tnicola merged commit f95d026 into tnicola:master Jan 28, 2022
@joshuajtward joshuajtward deleted the feat/add-reporterModulePath branch January 28, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants