Skip to content

Commit

Permalink
Allow clone to handle empty repos
Browse files Browse the repository at this point in the history
  • Loading branch information
ben committed Dec 14, 2012
1 parent be5869f commit 850b1ed
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/transports/local.c
Expand Up @@ -50,9 +50,11 @@ static int add_ref(transport_local *t, const char *name)
GITERR_CHECK_ALLOC(head->name);

if (git_reference_name_to_id(&head->oid, t->repo, name) < 0) {
/* This is actually okay. Empty repos often have a HEAD that points to
* a nonexistant "refs/haeds/master". */
git__free(head->name);
git__free(head);
return -1;
return 0;
}

if (git_vector_insert(&t->refs, head) < 0)
Expand Down
39 changes: 39 additions & 0 deletions tests-clar/clone/nonetwork.c
Expand Up @@ -86,3 +86,42 @@ void test_clone_nonetwork__fail_with_already_existing_but_non_empty_directory(vo
cl_git_mkfile("./foo/bar", "Baz!");
cl_git_fail(git_clone(&g_repo, g_origin, "./foo", &g_options));
}

void test_clone_nonetwork__can_clone_an_empty_local_repo_barely(void)
{
const char *src = cl_git_fixture_url("empty_bare.git");
cl_set_cleanup(&cleanup_repository, "./empty");

git_remote_free(g_origin);
cl_git_pass(git_remote_new(&g_origin, NULL, "origin", src, GIT_REMOTE_DEFAULT_FETCH));

cl_git_pass(git_clone_bare(&g_repo, g_origin, "./empty", NULL, NULL));
}

void test_clone_nonetwork__can_clone_an_empty_local_repo(void)
{
const char *src = cl_git_fixture_url("empty_bare.git");
cl_set_cleanup(&cleanup_repository, "./empty");

git_remote_free(g_origin);
cl_git_pass(git_remote_new(&g_origin, NULL, "origin", src, GIT_REMOTE_DEFAULT_FETCH));

cl_git_pass(git_clone(&g_repo, g_origin, "./empty", NULL, NULL, NULL));
}

void test_clone_nonetwork__can_clone_an_empty_standard_repo(void)
{
const char *src;

cl_git_sandbox_init("empty_standard_repo");
src = cl_git_path_url("./empty_standard_repo");

git_remote_free(g_origin);
cl_git_pass(git_remote_new(&g_origin, NULL, "origin", src, GIT_REMOTE_DEFAULT_FETCH));

cl_set_cleanup(&cleanup_repository, "./empty");

cl_git_pass(git_clone(&g_repo, g_origin, "./empty", NULL, NULL, NULL));

cl_git_sandbox_cleanup();
}

0 comments on commit 850b1ed

Please sign in to comment.