Allow AcmeTimeout to be configured with OPENSHIFT_ACME_TIMEOUT env #86
Conversation
|
Hi @seandilda. Thanks for your PR. I'm waiting for a tnozicka or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
seandilda
force-pushed
the
config_acme_timeout
branch
from
2e5eb2f
to
771fb11
Compare
pkg/cmd/cmd.go
Outdated
| @@ -96,6 +97,7 @@ func NewOpenShiftAcmeCommand(in io.Reader, out, err io.Writer) *cobra.Command { | |||
| rootCmd.PersistentFlags().StringP(Flag_ExposerListenIP, "", "0.0.0.0", "Listen address for http-01 server") | |||
| rootCmd.PersistentFlags().StringP(Flag_SelfNamespace_Key, "", "", "Namespace where this controller and associated objects are deployed to. Defaults to current namespace if this program is running inside of the cluster.") | |||
| rootCmd.PersistentFlags().StringP(Flag_DefaultRouteTermination_Key, "", string(routev1.InsecureEdgeTerminationPolicyRedirect), "Default TLS termination of the route.") | |||
| rootCmd.PersistentFlags().Int32P(Flag_Timeout, "", 60, "Timeout for talking to ACME server") | |||
There was a problem hiding this comment.
pls make it typed using DurationVarP
|
/ok-to-test |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
friendly ping @seandilda, would you mind adressing the requested changes and rebasing? |
…ironment variable
seandilda
force-pushed
the
config_acme_timeout
branch
from
771fb11
to
26ee48f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: seandilda The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @tnozicka |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
/remove-lifecycle rotten @tnozicka Any updates on this? |
|
@seandilda thanks for the PR, I've checked the V2 rewrite and there is a similar change incorporated which should cover the scenario To avoid conflicts with the rewrite, closing in favor of https://github.com/tnozicka/openshift-acme/pull/92/files#diff-7de04b860f288545dc225de20a47af16R127 /close |
|
@tnozicka: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I had problems running against an internal ACME server where the certs weren't always available within 60 seconds and hard coded timeout caused the request to fail.
This change allows the timeout to be changed per deployment.