Fix Content-Length return wrong length #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Proxy mode, Content-Length return wrong length in some Unicode cases.
For example:
"小方".length() // Output: 2
"小方".getBytes("UTF-8").length // Output: 6
As `Content-Length` defines the size of the body,
in above case `data.length()` always return the shorter length,
so the browser will cut left JavaScript code(Tested in chrome/Firefox).
Change to `data.getBytes().length`, parsing with bytes using the platform's default charset,
will get correct length.
*Content-Length Reference: http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.13
|
Thanks will check it soon. Would be nice to have a test case, but I can add that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for creating this awesome tool. I got a bug when using JSCover.
In Proxy mode, Content-Length return wrong length in some Unicode cases.
For example:
"小方".length() // Output: 2
"小方".getBytes("UTF-8").length // Output: 6
As
Content-Lengthdefines the size of the body,in above case
data.length()always return the shorter length,so _the browser will cut the left JavaScript code_ that causes syntax errors.
(Tested in chrome/Firefox).
Change to
data.getBytes().length, parsing with bytes using the platform's default charset,will get correct length.
*Content-Length Reference: http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.13