Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Proxy mode, is there a way to save files to original-src/ on store? #53

Closed
francesmcmullin opened this issue Mar 7, 2013 · 5 comments
Assignees
Labels

Comments

@francesmcmullin
Copy link

Sorry, this'll be my last issue I swear...

I've searched through the manual for this but couldn't find anything for this particular scenario. I'm running in proxy mode, and the coverage report is working beautifully, but when I hit store and try to access the report using a simple web server, I can only view the summary, because there's no JS in the original-src dir of the report. Is there a way to have the proxy server save the JS files it proxied when storing the report?

@tntim96
Copy link
Owner

tntim96 commented Mar 7, 2013

This looks broken. Should have it fixed in a day or so.

@tntim96
Copy link
Owner

tntim96 commented Mar 8, 2013

Sorry for that. There is an acceptance test for proxy report viewing that was working for v0.1.x, but continued to pass by chance test ordering when I broke this in v0.2.x. I've fixed the test and the code in trunk so you should be good to go. Let me know how you go.

@ghost ghost assigned tntim96 Mar 8, 2013
@francesmcmullin
Copy link
Author

Works great! Thanks so much! There's just one minor issue left... I think it's choking on a one-line try catch block. When I first hit store, it just gave me an error.log complaining about the following line :

try { dijit.selectInputText(focusNode, 0, 0); } catch(e) { }

So, going on a hunch, I changed it to :

try { 
  dijit.selectInputText(focusNode, 0, 0); 
} catch(e) { }

And it's working great now! Thanks for all the support, this tool is really really useful =)

@tntim96
Copy link
Owner

tntim96 commented Mar 8, 2013

Hmmm - that line run OK in isolation for me. Can you re-try, and possibly open a new issue and close this one?

@francesmcmullin
Copy link
Author

That's weird, it works now, must have been a coincidence with something else I was doing wrong. Everything works perfectly now with no exceptions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants