-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-fs needs to be last option #71
Comments
This is fixed in trunk. Are you able to build and verify? |
Is there a way that I can pull your commits into my fork? (Sorry, I am a bit new at Git/GitHub) Thanks, |
Sure. Just add my Git URL as a remote repository. I think the commands are: git clone https://github.com/grantwest/JSCover.git JSCover-grantwest
cd JSCover-grantwest
git remote add upstream https://github.com/tntim96/JSCover.git
git fetch upstream -v
git merge upstream/master Are you adding some features to be added back to trunk? |
The problem is fixed and this item can be closed. I may have something that can be added back into the trunk. It is a different way of setting up JSCover. A hybrid between File System mode and Server mode. I am preparing slide deck to explain it. I can give it to you when I am done so you can decided if you would like to incorporate my changes. I would be happy to help you if you would like. |
Thanks. I'll take a look at your slides when complete. Not sure if this is what your trying to achieve, but it's quite possible to get the file-system mode to save the report to the file-system with PhantomJS with minimal changes. |
In ConfigurationForFS.parse() it is assumed that the last 2 arguments in the args list are the srcDir and destDir respectively. Thus you put a different option at the end of the command line, it sets that option as the destDir path.
The 2 offending lines:
configuration.srcDir = new File(args[args.length - 2]);
configuration.destDir = new File(args[args.length - 1]);
The text was updated successfully, but these errors were encountered: